Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for copying files instead of moving them #13

Merged
merged 2 commits into from
Feb 4, 2018

Conversation

rask
Copy link
Contributor

@rask rask commented Sep 25, 2017

Adds a new composer.json config flag which allows devs to decide if the dropin files should be copied instead of moved from the source to the destination.

Adds a new composer.json config flag which allows devs to
decide if the dropin files should be copied instead of moved
from the source to the destination.
@rask
Copy link
Contributor Author

rask commented Sep 25, 2017

This PR implements #4.

@rask
Copy link
Contributor Author

rask commented Dec 21, 2017

@onnimonni could I get an update on this, is this OK, unwanted, or should I make changes? :)

@onnimonni
Copy link
Member

onnimonni commented Dec 21, 2017

Totally forgot this! Thanks for pinging.

What I would want you to do before merging this is to implement a test for this feature.

@rask
Copy link
Contributor Author

rask commented Dec 22, 2017

Sure thing, I'll try to get one up ASAP.

Also introduce composer test command and
alter test setup a little.
@rask
Copy link
Contributor Author

rask commented Dec 22, 2017

I altered the test setup quite a bit as the copy flag is project specific, now there are two test Composer packages in tests/. Worked locally but we have to see if the Travis config still works. I also added a composer test command to streamline local testing a little.

@onnimonni
Copy link
Member

Excellent! Travis is currently failing because of the github api limit. I need to fix that a bit later.

@rask
Copy link
Contributor Author

rask commented Dec 22, 2017

Ah OK. You can test it locally then before merging. 👍

EDIT: forgot to mention: as the changes are in my fork I locally substituted the composer.json package in tests directory to my fork and branch, as the changes are not yet merged into this repo.

@rask
Copy link
Contributor Author

rask commented Jan 26, 2018

@onnimonni did you have any time to check this out yet?

@onnimonni onnimonni merged commit bb0016b into Koodimonni:master Feb 4, 2018
@onnimonni
Copy link
Member

Thanks for adding this awesome feature and pinging me!

I have been too tired/busy to maintain this and I feel so terribly ashamed of myself.

I love the test helper you added:

$ composer test

@rask
Copy link
Contributor Author

rask commented Feb 4, 2018

No worries, personal stuff always comes first. 👍

Let me know if any issues come up with the new feature so I can jump in to help if needed.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants