-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for copying files instead of moving them #13
Conversation
Adds a new composer.json config flag which allows devs to decide if the dropin files should be copied instead of moved from the source to the destination.
This PR implements #4. |
@onnimonni could I get an update on this, is this OK, unwanted, or should I make changes? :) |
Totally forgot this! Thanks for pinging. What I would want you to do before merging this is to implement a test for this feature. |
Sure thing, I'll try to get one up ASAP. |
Also introduce composer test command and alter test setup a little.
I altered the test setup quite a bit as the copy flag is project specific, now there are two test Composer packages in |
Excellent! Travis is currently failing because of the github api limit. I need to fix that a bit later. |
Ah OK. You can test it locally then before merging. 👍 EDIT: forgot to mention: as the changes are in my fork I locally substituted the composer.json package in tests directory to my fork and branch, as the changes are not yet merged into this repo. |
@onnimonni did you have any time to check this out yet? |
Thanks for adding this awesome feature and pinging me! I have been too tired/busy to maintain this and I feel so terribly ashamed of myself. I love the test helper you added:
|
No worries, personal stuff always comes first. 👍 Let me know if any issues come up with the new feature so I can jump in to help if needed. Thanks! |
Adds a new composer.json config flag which allows devs to decide if the dropin files should be copied instead of moved from the source to the destination.